[codex] Bundle cookbook example data and remove yfinance#729
Draft
whenpoem wants to merge 1 commit intoPyPortfolio:mainfrom
Draft
[codex] Bundle cookbook example data and remove yfinance#729whenpoem wants to merge 1 commit intoPyPortfolio:mainfrom
whenpoem wants to merge 1 commit intoPyPortfolio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pypfopt.datamodule with loaders for bundled example prices, SPY prices, and Black-Litterman market capsyfinanceyfinancefrom thedevextra and add tests for the new data loadersWhy
Issue #716 tracks the cookbook notebooks' dependency on live
yfinancedownloads. That makes notebook CI depend on external network calls and changing upstream data. Bundling the example datasets keeps the notebooks reproducible and allowsnbmaketo run offline.Impact
yfinanceinstalled to run the notebook test suiteValidation
uv run --python .venv\Scripts\python.exe pytest ./testsuv run --python .venv\Scripts\python.exe pytest --reruns 3 --nbmake --nbmake-timeout=3600 -vv cookbookuv run --python .venv\Scripts\python.exe python -m build --sdist --wheel --outdir dist-check